593823 - Put tabs on top by default on Linux

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

We'll need to check with a hopefully representative range of Gtk themes whether tabs on top looks good enough to be the default state. The primary concern I have is that the menu bar is visually separated from the other toolbars and that the tabs would butt against this border, creating an uneasy appearance.

Comment 1

[antistress]

Dragging a tab button onto the personal tabs bar is less easy to me with tabs on top

Comment 2

[Yan Brodeur]

Attachment: Testcases for bug 593823

Comment 3

[Yan Brodeur]

[1] http://gnome-look.org/content/show.php/Above?content=123053
[2] http://gnome-look.org/content/show.php/Arta-Dark?content=115735
[3] http://gnome-look.org/content/show.php/BSM+Simple?content=121685
[4] http://gnome-look.org/content/show.php/Black+Human?content=120861
[5] http://gnome-look.org/content/show.php/Black-Diamond?content=94653
[6] http://gnome-look.org/content/show.php/Blue-Crystal?content=81401
[7] http://download.fedora.redhat.com/pub/fedora/linux/core/5/i386/os/Fedora/RPMS/redhat-artwork-0.241-1.i386.rpm
[8] http://gnome-look.org/content/show.php/Caramello?content=67476
[9] http://gnome-look.org/content/show.php/Classic+Bright?content=123389
[10] Probably installed by default
[11] http://gnome-look.org/content/show.php/Dark-linux?content=118548
[12] Probably installed by default
[13] http://gnome-look.org/content/show.php/Ecru?content=88871
[14] http://gnome-look.org/content/show.php/Espresso?content=113817
[15] http://gnome-look.org/content/show.php/Euphoria?content=120664
[16] http://gnome-look.org/content/show.php/FM1?content=123352
[17] http://gnome-look.org/content/show.php/Fundamental?content=117947
[18] http://iamfuss.deviantart.com/art/IAPTo1-141525996?q=gallery%3Acustomizers%2F23910472&qo=14&offset=0
[19] Probably installed by default
[20] Can't remember, sorry

Comment 4

[Dão Gottwald [:dao]]

Thanks!

Comment 5

[Yan Brodeur]

(In reply to comment #4)
> Thanks!

If you need more tell me.

Comment 6

[Dave Garrett]

Attachment: on KDE 4.4

I can't quite compare to the brilliant array posted by Yan, but here's a screenshot of tabs on top on KDE 4.4 with the default Oxygen theme and QtCurve for used for GTK. It looks great, as do all the others posted above.

Comment 7

[Dave Garrett]

(In reply to comment #0)
> The primary concern I
> have is that the menu bar is visually separated from the other toolbars and
> that the tabs would butt against this border, creating an uneasy appearance.

Some themes seem to do this on purpose and others don't. Even when they do, it doesn't look bad if that's what the theme was going for.

Everything I've seen thus far looks good and cross-platform consistency would be very good. I say flip the switch please. ;)

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 474676 [details] [diff] [review]
patch

get ui-review?

Comment 10

[Stephen Horlander [:shorlander]]

Comment on attachment 474676 [details] [diff] [review]
patch

The inability to extend the menu bar color behind the tabs isn't ideal. It works really well in most cases though.

Comment 11

[Dave Garrett]

Requesting blocking beta7+ just to make sure this is on the radar, as a lot of Linux users have been complaining about the delay for this.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

It doesn't block beta 7, and I don't think it blocks final either. I'll get the approval request evaluated.

Comment 13

[Dave Garrett]

Regardless of blocking then, is this on track for approval2.0+ before beta 7?

Comment 14

[Dave Garrett]

Status? Shouldn't this at least be able to land on Trunk for beta 8?

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 474676 [details] [diff] [review]
patch

a=beltzner, can go for beta7

Comment 16

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/b4e2b4ad8a5d